Add the last few lines needed to show a new user how the Collector/Gatherer fits together #495
Conversation
|
|
||
| // Because we've registered these metrics to a new non-default Registry | ||
| // we need to tell it to servce them separately | ||
| http.Handle("/metrics/inner", promhttp.HandlerFor(reg, promhttp.HandlerOpts{})) |
There was a problem hiding this comment.
I would not recommend to serve those metrics separately.
If you would like to see the standard process and Go metrics, it's better to register the respective collectors with the custom registry. It might actually be a good idea to demonstrate that here, turning this into a very comprehensive example.
There was a problem hiding this comment.
aha, another thing i haven't worked out how to do - will do some more reading :)
There was a problem hiding this comment.
The code is the following:
reg.MustRegister(
prometheus.NewProcessCollector(prometheus.ProcessCollectorOpts{}),
prometheus.NewGoCollector(),
)There was a problem hiding this comment.
ping Would you like to add the above and then remove the exposition of the default registry?
There was a problem hiding this comment.
yup, sorry, $work is distracting :)
| http.Handle("/metrics/inner", promhttp.HandlerFor(reg, promhttp.HandlerOpts{})) | ||
|
|
||
| // The default golang metrics | ||
| http.Handle("/metrics", prometheus.Handler()) |
There was a problem hiding this comment.
In the spirit of the above, I would drop this line.
SvenDowideit
force-pushed
the
add-extra-hints-to-clustermanager-example
branch
from
913cd43 to
218f588
Compare
…therer fits together Signed-off-by: Dowideit, Sven (O&A, St. Lucia) <Sven.Dowideit@csiro.au>
SvenDowideit
force-pushed
the
add-extra-hints-to-clustermanager-example
branch
from
218f588 to
8324e65
Compare
|
aha, and that simplifies the code i'm using too - worth iterating - thanks for taking the time :) |
|
Thank you, too. |
2 participants
Or if that's too verbose, can we just add the
http.Handle("/metrics/inner", promhttp.HandlerFor(reg, promhttp.HandlerOpts{}))line to help the new user?