Remove use of deprecated procfs functions #593
Conversation
Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
|
|
||
| // Set up process metric collection if supported by the runtime. | ||
| if _, err := procfs.NewStat(); err == nil { | ||
| if _, err := procfs.NewDefaultFS(); err == nil { |
There was a problem hiding this comment.
I don't know the internals, but previously we are checking if we can ready the data correctly, but with this change we will be checking if the procfs mount exists. Not sure if that is enough.
There was a problem hiding this comment.
You are right, previously we also tested actually reading the proc stats.
However, that was not a guarantee that it would always work. For example, if somebody removed the read permissions on the proc files, it would fail at the next collection. Thus, we always had error handling in place to deal with that.
The initial test was mostly there to weed out platforms that have no procfs support in general so that we avoid trying it out on each collect cycle again.
Arguably, the way this change changes it is even better: If there is no procfs at all, it will prevent collection for good. If there is a procfs but it is not readable, that might be a temporary problem, so it makes sense to try on each collect cycle again. (Needless to say that all of this are very rare corner cases.)
There was a problem hiding this comment.
Agreed, 👍 This PR is good to go!
2 participants
@pgier