Cut v1.2.0 #658
Merged
Cut v1.2.0 #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The part after the underscore has to be lowercase. Otherwise, it is seen as the name of a Go type, which doesn't exist, which will result in the example not showing up in godoc. Signed-off-by: beorn7 <beorn@grafana.com>
Just to make sure we are up to date before releasing. This only affects golang.org/x/sys. Signed-off-by: beorn7 <beorn@grafana.com>
One might argue that supporting the newest Pushgateway is just an enhancement or even a bugfix (and this should be v1.1.1, which would be a really nice version number). I decided to go for a positive view of things and call it a feature. If something else changes its behavior, it's not really a bug from client_golang's point of view. Signed-off-by: beorn7 <beorn@grafana.com>
csmarchbanks
approved these changes
Oct 15, 2019
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a capitalization issue in the godoc examples for the API. See commit description.
Interestingly, no breaking changes in the API client. Is it approaching stability? :o)