Handle process collector errors gracefully #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is expected that the process collector can fail under certain conditions (proc information for a process only readable by root or other user for example) and as there is currently no option to configure the error behavior of the client, this change reverts the error reporting introduced in 159e96f. This effectively means that errors are simply ignored and there won't be any samples for the process_* metrics in case of an error. Once a user can control how to behave in case of errors returned by collectors, this change should probably be reverted.
|
👍 |
|
It feels a bit weird to do... nothing (no logs, no error counter) when an error occurs, but since errors are going to be the norm in certain environments (chroot), I guess that's the way to go. 👍 |
|
And let's revisit once we have more granular error handling. |
|
👍 But perhaps add a TODO with this commit as a reference so that you can put it back once error handling is more configurable? |
grobie
added a commit
that referenced
this pull request
Feb 11, 2015
…s-gracefully Handle process collector errors gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is expected that the process collector can fail under certain
conditions (proc information for a process only readable by root or
other user for example) and as there is currently no option to configure
the error behavior of the client, this change reverts the error
reporting introduced in 159e96f. This effectively means that errors are
simply ignored and there won't be any samples for the process_* metrics
in case of an error.
Once a user can control how to behave in case of errors returned by
collectors, this change should probably be reverted again.
@beorn7 @juliusv @brian-brazil