Skip to content

Add type annotations to parser.py #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

Add type annotations to parser.py #887

merged 1 commit into from
Feb 7, 2023

Conversation

zhanpon
Copy link
Contributor

@zhanpon zhanpon commented Feb 6, 2023

@csmarchbanks Hi. Thank you for maintaining the project!

I've added type annotations to the functions in parser.py (issue: #491)

@zhanpon
Add type annotations to parser.py
66ecd51 
Signed-off-by: Yiyang Zhan <pon.zhan@gmail.com>
csmarchbanks
csmarchbanks approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I am not sure why CI is not running but I ran all tests locally and will merge anyway.

@csmarchbanks csmarchbanks merged commit d27cb27 into prometheus:master Feb 7, 2023
@zhanpon zhanpon deleted the type-parser branch February 7, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhanpon @csmarchbanks