Skip to content

Conversation

porras
Copy link
Contributor

@porras porras commented Nov 5, 2013

Adds a (very basic and simple) gemspec.

@matttproud
Copy link

LGTM.

@grobie
Copy link
Member

grobie commented Nov 5, 2013

Be aware that the client is not really ready yet, that's why I haven't added the gemspec yet. Histrogram is not yet available and it lacks support for the new output formats (protobufs, content negotiation, etc.).

Unfortunately, I'm not sure it makes sense to use the client in this form. I might be able to make the minimum changes this week. @porras would you be ok to live without histograms and just counters for now?

@porras
Copy link
Contributor Author

porras commented Nov 5, 2013

@grobie It's ok for our small app to use just counters (that's why I'm using it) and I think it makes sense to use this client in order to try it and push it forward (I'm happy to help with that fixing whatever glitch I may find).

@matttproud
Copy link

@grobie, we should do a video chat in the next few weeks if you're up for it. Given the changes we've made in upstream Protocol Buffers for Ruby (beefcake) and the existence of Ruby Quantile Estimation (http://rubygems.org/gems/quantile), I think we can knock out this client library even faster without needing to implement the histograms as they were in the Go reference client.

@grobie
Copy link
Member

grobie commented Nov 5, 2013

@porras Do you use the current client lib with a prometheus server already? I'm not sure the current servers are still able to scrape the old format exposed by this library. That's why I'm unsure about releasing it in this state. @matttproud any insights here?

@matttproud Sounds good, anything next week should work for me.

@matttproud
Copy link

Old wireformats continue to work. :)

/CC: @juliusv

@porras
Copy link
Contributor Author

porras commented Nov 5, 2013

@grobie not really, I was going to setup it today, @juliusv told me he thought it would be fine. My plan was just try it and make any needed changes in case it doesn't work, do you think it's an overoptimistic plan? ;)

@grobie
Copy link
Member

grobie commented Nov 5, 2013

@porras Of course not, optimists are awesome :D

Did some small changes: 60437d2, but enjoy: http://rubygems.org/gems/prometheus-client

@grobie grobie closed this Nov 5, 2013
@porras
Copy link
Contributor Author

porras commented Nov 5, 2013

Thanks you all!

@porras porras deleted the gemspec branch November 5, 2013 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants