Skip to content

Make suggested tweaks to README from feedback in #95 #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2019
Merged

Make suggested tweaks to README from feedback in #95 #120

merged 1 commit into from
May 5, 2019

Conversation

Sinjo
Copy link
Member

@Sinjo Sinjo commented May 3, 2019 •
edited
Loading

  • Don't suggest defining metrics outside of file they're used in
  • Don't allow stores to require extra parameters in for_metric
  • Correct note on kernel page cache

Fixes #113, Fixes #114

@Sinjo Sinjo requested a review from dmagliola May 3, 2019 14:20
Make suggested tweaks to README from feedback in #95
c085906 
  - Don't suggest defining metrics outside of file they're used in
  - Don't allow stores to require extra parameters in `for_metric`
  - Correct note on kernel page cache

Fixes #113, #114

Signed-off-by: Chris Sinjakli <chris@gocardless.com>
@Sinjo Sinjo force-pushed the sinjo-readme-tweaks branch from 2c7589d to c085906 Compare May 3, 2019 14:22
@coveralls
Copy link

coveralls commented May 3, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c085906 on sinjo-readme-tweaks into 460c2bb on master.

@brian-brazil
Copy link

👍

@Sinjo Sinjo merged commit ff8a62b into master May 5, 2019
@Sinjo Sinjo deleted the sinjo-readme-tweaks branch May 5, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmagliola dmagliola dmagliola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove mentions of "required settings" in for_metric args from docs Minor tweaks to README based on @brian-brazil’s feedback
4 participants
@Sinjo @coveralls @brian-brazil @dmagliola