Minor wordsmithing in README.md #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinjo
force-pushed
the
sinjo-wordsmithing
branch
from
f8894c4 to
d1d9a61
Compare
dmagliola
reviewed
Mar 24, 2021
README.md
Outdated
| **Declare metrics before fork**: As well as deleting files before your process forks, you | ||
| should make sure to declare your metrics then too. Because the metric registry is held in | ||
| memory, any metrics declared after forking will only be present in child processes where | ||
| the code declaring them ran, and as a result won't be consistently exported when scraped |
There was a problem hiding this comment.
I'd say "may not be" rather than "won't".
The reason is that if your code consistently declares metrics (and i'm not sure how this doesn't happen), you can totally declare them after fork and it's fine. For example, if your metrics get declared when Ruby executes the class definitions.
dmagliola
reviewed
Mar 24, 2021
README.md
Outdated
| Indeed, even if the content of the metric is stored in a file, the list of all metrics is | ||
| stored in memory. Creating metrics after fork would lead to unexported files metrics. | ||
| **Declare metrics before fork**: As well as deleting files before your process forks, you | ||
| should make sure to declare your metrics then too. Because the metric registry is held in |
There was a problem hiding this comment.
declare your metrics then too
I find that "then too" a bit unclear as to when it is.
Can we make it more redundant but clear, something like you should also make sure to declare your metrics before the fork
dmagliola
approved these changes
Mar 24, 2021
Sinjo
force-pushed
the
sinjo-wordsmithing
branch
from
d1d9a61 to
d3ca0ab
Compare
Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Sinjo
force-pushed
the
sinjo-wordsmithing
branch
from
d3ca0ab to
db75ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.