Skip to content

Conversation

Sinjo
Copy link
Member

@Sinjo Sinjo commented Mar 24, 2021

Fixes #202

Tested the fix on 2.7.2 with the push gateway running locally and it seems to do the trick:

sinjo@coin:~/projects/client_ruby$ bx irb
irb(main):001:0> require "prometheus/client/push"
=> true
irb(main):002:0> registry = Prometheus::Client.registry
=> #<Prometheus::Client::Registry:0x00005620d98717e8 @metrics={}, @mutex=#<Thread::Mutex:0x00005620d9871658>>
irb(main):003:0> Prometheus::Client::Push.new('test-job').add(registry)
=> #<Net::HTTPOK 200 OK readbody=true>

@Sinjo Sinjo requested a review from dmagliola March 24, 2021 00:48
Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
@coveralls
Copy link

coveralls commented Mar 24, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 4f95dd0 on sinjo-add-missing-require into 76e3cb8 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4f95dd0 on sinjo-add-missing-require into 76e3cb8 on master.

@Sinjo Sinjo merged commit 7635b8f into master Mar 24, 2021
@Sinjo Sinjo deleted the sinjo-add-missing-require branch March 24, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CGI not required properly in prometheus/client/push.rb
3 participants