Add squid exporter #1154
Merged
Add squid exporter #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
reviewed
Aug 20, 2018
| @@ -89,6 +89,7 @@ wide variety of JVM-based applications, for example [Kafka](http://kafka.apache. | |||
| * [Tinyproxy exporter](https://github.com/igzivkov/tinyproxy_exporter) | |||
| * [Varnish exporter](https://github.com/jonnenauha/prometheus_varnish_exporter) | |||
| * [WebDriver exporter](https://github.com/mattbostock/webdriver_exporter) | |||
| * [Squid exporter](https://github.com/boynux/squid-exporter) | |||
There was a problem hiding this comment.
Please put this above Tinyproxy so the list remains in alphabetical order.
|
As Ben said, please keep it sorted. Usually you'd have a single flag for host:port, the code is just joining them together again so you could make it a little simpler by doing so. Considering you have to list all the metrics you want, you should consider fixing the metric names (e.g. all counters should end in _total) and units while you're at it. |
Signed-off-by: Mohamad Arab <boynux@gmail.com>
|
@brian-brazil sure, I'll add your suggestion to the exporter Github repo and fix them accordingly. Thanks. |
|
Thanks! |
This was referenced Aug 20, 2018
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
Signed-off-by: disksing <i@disksing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds squid exporter to the exporters list.
@brian-brazil can you have a look please?