-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wechat configuration #977
Conversation
|
||
```yaml | ||
# Whether or not to notify about resolved alerts. | ||
[ send_resolved: <boolean> | default = true ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we sending resolved messages to a chat system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed too.
|
||
# API request data as defined by the Wechat API. | ||
[ message: <string> | default = '{{ template "wechat.default.message" . }}' ] | ||
[ agent_id: <string> | default = '{{ template "wechat.default.agent_id" . }}' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right, this field isn't templated so why does it have that default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you're right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, in work WeChat, a agent_id
means a chat room, so I think agent_id
should be a categoric value, no need template, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I've got prometheus/alertmanager#1253 to remove those.
b583ca4
to
0d75e9c
Compare
|
||
## `<wechat_config>` | ||
|
||
Wechat notifications are sent via the [Wechat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Wechat" -> "WeChat"
# Whether or not to notify about resolved alerts. | ||
[ send_resolved: <boolean> | default = false ] | ||
|
||
# The API key to use when talking to the Wechat API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Wechat" -> "WeChat"
# The API key to use when talking to the Wechat API. | ||
[ api_secret: <secret> | default = global.wechat_secret_url ] | ||
|
||
# The Wechat API URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Wechat" -> "WeChat"
# The corp id for authentication | ||
[ corp_id: <string> | default = global.wechat_api_corp_id ] | ||
|
||
# API request data as defined by the Wechat API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Wechat" -> "WeChat"
# The Wechat API URL. | ||
[ api_url: <string> | default = global.wechat_api_url ] | ||
|
||
# The corp id for authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Period at end of comment line.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
4a43741
to
aab7d2b
Compare
@juliusv thanks for the review! |
I'll wait for @juliusv to approve/merge |
Fixes #1005.