Skip to content

Update dependencies, drop unsupported ruby versions, create rubocop todo #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

zhulik
Copy link
Contributor

@zhulik zhulik commented Feb 20, 2023

Initially I wanted to only update faraday, but found out that almost everything is outdated.

Changes:

  • Update faraday minimal version and adjust it's config to using the net_http adapter
  • Remove all mentions of ruby < 3 in the Gemfile
  • Update rubocop, adjust it's config and generate a todo list. Older versions of rubocop simply do not support newer version of ruby
  • Set required_ruby_version to >= 3.0.0
  • Remove testing against EoL versions of ruby, run tests against supported ruby versions

Tests and rubocop are green.

TODO:

  • Test against prometheus. UPD: it works correctly

If you don't mind and everything is ok with these changes, I'll also open a couple of follow ups to deal with rubocop todos and enable new cops.

What do you think about moving from travis to github workflows? UPD: is travis even working?

Signed-off-by: Gleb Sinyavskiy <zhulik.gleb@gmail.com>
Signed-off-by: Gleb Sinyavskiy <zhulik.gleb@gmail.com>
Signed-off-by: Gleb Sinyavskiy <zhulik.gleb@gmail.com>
@yaacov
Copy link
Member

yaacov commented Feb 21, 2023

hi, thank you

@yaacov yaacov merged commit af8900e into prometheus:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants