-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer tweaks #15
Composer tweaks #15
Conversation
jsor
commented
Aug 20, 2014
- Moved autoloading of test classes to autoload-dev. This should be a no-brainer.
- Made zendframework/zend-db an optional dependency. Not sure if you really want this. I will write a Doctrine adapter for my current project as it already uses Doctrine (i can contribute it back if you're interested), so i don't need Zend\Db. If you don't like this change, feel free to only cherry-pick the other commit.
FYI: first version of my Doctrine adapter: https://github.com/dotsunited/prooph-event-store-doctrine-adapter |
Define zend-db and zend-serializer as optional requirement is a good idea. Your doctrine dbal adapter is a good alternative for all users that are more familiar with doctrine than with zend-db. If you want to use doctrine for the read side it makes sense to use it also as adapter for the write side. Would be great to have your adapter included in ProophEventStore. I will add more adapters in the future like an adapter for mongoDB. |
Feel free to pull in my adapter. |
I will follow your suggestion. I will put the ZF2EventStoreAdapter in a separate package, too. This way I can require zend-db and zend-serializer when it's really needed and your package can require doctrine dbal. I will point to both packages in the EventStore readme so everybody can choose his favorite adapter. |
Btw, if you like i can move dotsunited/prooph-event-store-doctrine-adapter over to the prooph organisation. |
Would be great to have your adapter under the prooph namespace. When the transfer is done, I will give you write access for the repo. I will change the repository and aggregate handling of the ES in Version 0.5.0. The ES itself will no longer know anything about aggregates and repositories. From 0.5.0 on it will only know streams and their events. It will be the task of the user to organize the streams (f.e. one Stream per Aggregate, one Stream per AggregateType or one Stream for all Aggregates). |
Sounds great! Feel free to create a repository under the prooph organisation and push my code to it. I tried to move the repo to prooph, but to do this, one need admin rights at the target org. I'm at vacation currently (and will be for the 2 weeks) and will delete the repo once i'm back. Note that there 2 differences to the Zend\Db adapter
|
I've decided to only fork the repo so that everybody can find it on the prooph overview page. If I would create a new repo and only push your code to it the history get lost. It's your work and a good promotion that the EventStore can be extended very easy. I will send you a pull request when I changed the adapter interface. |
To keep the history, just create a new repo under prooph, clone my repo, and change the remote to the prooph repo and push. I think the fork could confuse people becaue they will be unsure what to use. They will prefer the prooph repo since it looks more official but the repo will be mostly not in sync with original. |
ok, thank you for the tip. I've moved the repo now. Btw. you can find a first draft of the 0.5.0 Version of the ES in current development branch of the EventStore. |
Cool, i will look at it when i'm back from vacation. |