Update fromStream for Projection, Query and ReadModelProjection

[fjogeleit]

This change make it possible to query for a single aggregate with a SingleStream- and SimpleStreamStrategy behind.

[coveralls]

Coverage increased (+0.002%) to 99.009% when pulling 68a823c on fjogeleit:master into c71cc42 on prooph:master.

[gquemener]

One use case I see for that is when projection only relies on a subset of the events (by type for instance).

Is that what you had in mind as well?
I'm wondering if there is a reason why this wasn't in the interface already?

[gquemener]

This is a BC break and should be released in a new major version, shouldn't it?

[prolic]

Exactly, my bad. I think this should work:
public function fromStream(string $streamName, MetadataMatcher $metadataMatcher = null): Query;

[fjogeleit]

My main reason for this is to have the possibility to filter the stream by the aggregateID to calculate additional data bei a given time range. But its also possible to filter by type, version and so on. You can also add custom meta data to your events and filter by it.

[prolic]

Additionally I'd like to have this functionality in Projection and ReadModelProjection as well.

[prolic]

Exactly, my bad. I think this should work:
public function fromStream(string $streamName, MetadataMatcher $metadataMatcher = null): Query;

[prolic]

Looks good so far. Before merging this, I'd like to see two things.

1. implementation for pdo event store
2. docs

[fjogeleit]

A PR for the PDO Event Store is already open: prooph/pdo-event-store#177

Docs will be updated asap

[prolic]

The change is only in implementation, not in the interface itself.

…

On Sat, Nov 3, 2018, 23:33 Gildas Quéméner ***@***.*** wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Projection/ReadModelProjector.php <#350 (comment)>: > @@ -35,7 +36,7 @@ */ public function init(Closure $callback): ReadModelProjector; - public function fromStream(string $streamName): ReadModelProjector; + public function fromStream(string $streamName, MetadataMatcher $metadataMatcher = null): ReadModelProjector; Changing a method signature (even with optional parameters) is a BC break and all custom implementations will break after this change. php > interface X php > { php { public function foo(string $a, int $b = null): void php { ; php { } php > class A implements X php > { php { public function foo(string $a): void php { { php { } php { } Fatal error: Declaration of A::foo(string $a): void must be compatible with X::foo(string $a, ?int $b = NULL): void in php shell code on line 1 A BC solution would have been to create a separate interface, which would have provided the fromStreamWithMetadataMatcher method OR to release this in a new major version. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvBT3x0N6jiL2AFVk38NgGhh2SxKnks5urbdYgaJpZM4YII9M> .

[gquemener]

Oh right, I see. Sorry, I got confused with the github discussion feed.

[prolic]

No problem

…

On Sat, Nov 3, 2018, 23:40 Gildas Quéméner ***@***.*** wrote: Oh right, I see. Sorry, I got confused with the github discussion feed. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvIndheI0TUOcC5Ttf4Nn-75WXUWGks5urbjbgaJpZM4YII9M> .