setters should provide fluent interface #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setNew, setDeleted and resetModified should return $this as all the other setters to provide fluent interface.
|
you should provide unit tests supporting your change |
|
Looks good to me, including the tests 👍 |
willdurand
added a commit
that referenced
this pull request
Dec 31, 2013
setters should provide fluent interface
willdurand
added a commit
that referenced
this pull request
Feb 17, 2014
Providing tests for proposal #804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setNew, setDeleted and resetModified should return $this as all the other setters to provide fluent interface.