Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter table syntax for migration with SQL Server is incorrect #1343

Open
cameronstubber opened this issue Feb 8, 2017 · 7 comments
Open
Assignees
Labels

Comments

@cameronstubber
Copy link

The current syntax created does not work:

ALTER TABLE [table] ADD
(
    [column1] <type> <options>,
    [column2] <type> <options>,
    [column3] <type> <options>
);

The following syntax does work:

ALTER TABLE [table] ADD [column1] <type> <options>;
ALTER TABLE [table] ADD [column2] <type> <options>;
ALTER TABLE [table] ADD [column2] <type> <options>;
@cameronstubber
Copy link
Author

@marcj please assign this issue to me.

@MDT-FGI
Copy link

MDT-FGI commented Feb 13, 2017

Duplicate of #1294

atompulse added a commit to atompulse/Propel2 that referenced this issue Aug 28, 2017
propelorm#1294
propelorm#1343
Solved:
- size checking issue
- default values issue
- foreign keys actions (on delete/on update)
Remaining:
- sql syntax for alter table
atompulse added a commit to atompulse/Propel2 that referenced this issue Aug 29, 2017
atompulse added a commit to atompulse/Propel2 that referenced this issue Aug 31, 2017
atompulse added a commit to atompulse/Propel2 that referenced this issue Nov 22, 2017
propelorm#1294
propelorm#1343
Solved:
- size checking issue
- default values issue
- foreign keys actions (on delete/on update)
Remaining:
- sql syntax for alter table
atompulse added a commit to atompulse/Propel2 that referenced this issue Nov 22, 2017
atompulse added a commit to atompulse/Propel2 that referenced this issue Nov 22, 2017
@cameronstubber
Copy link
Author

@atompulse is this something you have fixed? Making the ALTER TABLE syntax do one command per change, instead of ( ALLCHANGES );

@cameronstubber
Copy link
Author

@marcj since I dont know how to message you, I will comment. I have a question. Should the version number in propel.php not be updated to 2.0.0-alpha8? I am trying to get alpha8 to check what changes @atompulse has made before I go trying to fix something that isnt broken, but even though I put 2.0.0-alpha8 in my composer.json file, when I run propel, it says version 2.0.0-dev or master whatever it is. What am I missing?

@atompulse
Copy link
Contributor

@cameronstubber I have an active project using MSSQL and I believe that most of the issues should be fixed by my commits.

@cameronstubber
Copy link
Author

cameronstubber commented Apr 6, 2018 via email

@atompulse
Copy link
Contributor

@cameronstubber you are not able to fork my version at https://github.com/atompulse/PropelBundle ?
I use it in my projects with these composer seetings:

"repositories": [
    {
      "type": "vcs",
      "url": "https://github.com/atompulse/PropelBundle",
      "no-api": true
    },
    {
      "type": "vcs",
      "url": "https://github.com/atompulse/Propel2",
      "no-api": true
    }
  ]
...
"require": {
...
"propel/propel-bundle": "3.0.x-dev"
...
}

@dereuromark dereuromark added the Bug label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants