Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up in array strictness for string value comparison. #1953

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

dereuromark
Copy link
Contributor

@dereuromark dereuromark commented Jan 25, 2023

Now that we are using more string types, the type going into those is usually quite clear.
This makes it a bit faster but more importantly avoids false positive comparison in some cases where casting would create wrong results.

Follow #1951

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 88.63% // Head: 88.63% // No change to project coverage 👍

Coverage data is based on head (76346ae) compared to base (5531e13).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1953   +/-   ##
=========================================
  Coverage     88.63%   88.63%           
  Complexity     8019     8019           
=========================================
  Files           243      243           
  Lines         24549    24549           
=========================================
  Hits          21759    21759           
  Misses         2790     2790           
Flag Coverage Δ
5-max 88.63% <92.85%> (ø)
7.4 88.63% <92.85%> (ø)
agnostic 67.39% <67.85%> (ø)
mysql 69.13% <64.28%> (ø)
pgsql 69.17% <67.85%> (ø)
sqlite 67.15% <57.14%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Propel/Generator/Model/Table.php 90.56% <50.00%> (ø)
src/Propel/Runtime/Map/ColumnMap.php 77.16% <75.00%> (ø)
...ltipleColumns/AggregateMultipleColumnsBehavior.php 96.18% <100.00%> (ø)
src/Propel/Generator/Builder/Om/QueryBuilder.php 91.32% <100.00%> (ø)
src/Propel/Generator/Model/Column.php 95.96% <100.00%> (ø)
src/Propel/Generator/Model/Database.php 72.78% <100.00%> (ø)
src/Propel/Generator/Model/Domain.php 84.48% <100.00%> (ø)
src/Propel/Generator/Model/Index.php 97.84% <100.00%> (ø)
src/Propel/Generator/Platform/DefaultPlatform.php 94.60% <100.00%> (ø)
src/Propel/Generator/Platform/MysqlPlatform.php 95.69% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereuromark dereuromark merged commit 912ddae into master Jan 25, 2023
@dereuromark dereuromark deleted the bugfix/cleanup-in-array branch January 25, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants