Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read "propel_converter" options from request attributes #449

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Feb 27, 2017

closes #448

@gharlan
Copy link
Contributor Author

gharlan commented Mar 13, 2017

ping @havvg and @marcj

On many pages in my app it brings a performance boost of ~40%.

screenshot 2017-03-13 11 08 40

@gharlan
Copy link
Contributor Author

gharlan commented Mar 13, 2017

On many pages

Pages where I'm using implicit ParamConverters like this:

    /**
     * @Route("/foo/{id}", name="foo.view")
     */
    public function fooAction(Request $request, Foo $foo)
    {
    }

@gharlan
Copy link
Contributor Author

gharlan commented Jun 26, 2017

ping :)

@gharlan
Copy link
Contributor Author

gharlan commented Aug 31, 2017

ping ;)

@marcj marcj merged commit 4df8ff6 into propelorm:3.0 Aug 31, 2017
@marcj
Copy link
Member

marcj commented Aug 31, 2017

Sorry, @havvg is away somehow. Merged, thanks :)

@gharlan gharlan deleted the propel-converter branch August 31, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants