Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panels as parasite child axes instead of embedding them in the gridspec #46

Closed
wants to merge 2 commits into from
Closed

Add panels as parasite child axes instead of embedding them in the gridspec #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32e3b9
Initial pull request
lukelbd Sep 18, 2019
b7e7625
Add colorbar, legend, and text methods to axes_grid as starting point
lukelbd Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 14 additions & 18 deletions proplot/subplots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,24 +295,20 @@ def _iterator(*args, **kwargs):
# Mixed
raise AttributeError(f'Found mixed types for attribute {attr!r}.')

# TODO: No more putting panels, legends, colorbars on the SubplotSpec.
# Put them in the margin, increase default space, and lock them to
# subplot bounds with locators, borrowing from axes_grid1 toolkit
# TODO: Consider adding Github issue, would be major API change.
# def colorbar(self, loc=None):
# """Draws a colorbar that spans axes in the selected range."""
# for ax in self:
# pass
#
# def legend(self, loc=None):
# """Draws a legend that spans axes in the selected range."""
# for ax in self:
# pass
#
# def text(self, loc=None):
# """Draws text that spans axes in the selected range."""
# for ax in self:
# pass
def colorbar(self, loc=None):
"""Draws a colorbar that spans axes in the selected range."""
for ax in self:
pass

def legend(self, loc=None):
"""Draws a legend that spans axes in the selected range."""
for ax in self:
pass

def text(self, loc=None):
"""Draws text that spans axes in the selected range."""
for ax in self:
pass

#-----------------------------------------------------------------------------#
# Gridspec classes
Expand Down