Updating default fill styles - previous values were incorrect

[bendalton]

Previous values resulted in a styles.xml with:

  <fills count="2">
    <fill>
      <patternFill patternType="solid">
        <bgColor/>
      </patternFill>
    </fill>
    <fill>
      <patternFill patternType="solid">
        <bgColor/>
      </patternFill>
    </fill>
  </fills>

instead of the expected:

 <fills count="2">
    <fill>
      <patternFill patternType="none"/>
    </fill>
    <fill>
      <patternFill patternType="gray125"/>
    </fill>
  </fills>

[bendalton]

This caused some nasty issues when attempting to render the xlsx file outside of Excel. For example: http://note.io/1BKBfIQ

[pietersv]

Thanks!

[bendalton]

Did you end up merging this in?

[protobi]

Done. Turns out there was a really arcane issue with xls files related to
gray125 yelding an out of memory error, so tweaked it a tiny bit further.
This gray125 issue maybe even date back to the first release of Office for
Mac, as that pattern totally reminds me of the early Macintosh days.

[image: Inline image 1]

On Thu, Jun 4, 2015 at 10:35 AM, Ben Dalton notifications@github.com
wrote:

Did you end up merging this in?

—
Reply to this email directly or view it on GitHub
#3 (comment).

Pieter Sheth-Voss PhD

protobi
e: pieter@protobi.com
m: 617.645.4524

[bendalton]

Wow. Thanks!
On Thu, Jun 4, 2015 at 12:09 PM Pieter Sheth-Voss notifications@github.com
wrote:

Done. Turns out there was a really arcane issue with xls files related to
gray125 yelding an out of memory error, so tweaked it a tiny bit further.
This gray125 issue maybe even date back to the first release of Office for
Mac, as that pattern totally reminds me of the early Macintosh days.

[image: Inline image 1]

On Thu, Jun 4, 2015 at 10:35 AM, Ben Dalton notifications@github.com
wrote:

Did you end up merging this in?

—
Reply to this email directly or view it on GitHub
#3 (comment).

Pieter Sheth-Voss PhD

protobi
e: pieter@protobi.com
m: 617.645.4524

—
Reply to this email directly or view it on GitHub
#3 (comment).