Feature/apply html design #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 7, 2019 13:51
Agupane
suggested changes
Jan 7, 2019
There was a problem hiding this comment.
@mariano-aguero could you move card; customButtons and custom input to /Common/UI please?
Also the template is not centered and is not responsive, this should be corrected on the next milestone but just to let you know.
The subscribe/unsubscribe buttons are not clickable, maybe the btnHandler function is not defined or passed as props, could you check it again please?
Also in /account/subscription the input is not usable neither the subscribe button, it could be maybe related to my bonded status, but I don't have an valid bonded address to test it
|
The template is also responsive, we can check this using chrome dev tools, and compare the integration with the template in heroku Regards |
Agupane
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 6 from backend
Apply design