Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/limits solidity pragma of 0.5.x version of API #82

Merged
merged 1 commit into from
Mar 22, 2019
Merged

fix/limits solidity pragma of 0.5.x version of API #82

merged 1 commit into from
Mar 22, 2019

Conversation

gskapka
Copy link
Collaborator

@gskapka gskapka commented Mar 22, 2019

...per title.

@gskapka gskapka added the quick fix Small changes that make quick fixes. label Mar 22, 2019
@gskapka gskapka self-assigned this Mar 22, 2019
riccardopersiani
riccardopersiani approved these changes Mar 22, 2019
View reviewed changes
Copy link

@riccardopersiani riccardopersiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

D-Nice
D-Nice approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@D-Nice D-Nice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caveat, it will permit 0.6.0 nightly, as solc considers it part of previous minor version iirc.

@D-Nice D-Nice merged commit b7a62b4 into master Mar 22, 2019
@D-Nice D-Nice deleted the fix/limit-solidity-pragma branch March 22, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D-Nice D-Nice D-Nice approved these changes

@riccardopersiani riccardopersiani riccardopersiani approved these changes

Assignees

@gskapka gskapka

Labels
quick fix Small changes that make quick fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gskapka @D-Nice @riccardopersiani