Skip to content

Conversation

devils2ndself
Copy link
Contributor

@devils2ndself devils2ndself commented Oct 23, 2022

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

Resolves #2721

What changes did you make? (Give an overview)

Made KSQL Request -> Stream Properties input tags responsive, resolving the overflow that was before.

Is there anything you'd like reviewers to focus on?

Maybe different resolutions. It worked fine at 1080p and was overflowing below 720p. Now should be working just fine at any resolution.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image_2022-09-08_15-10-47

@devils2ndself devils2ndself requested a review from a team as a code owner October 23, 2022 00:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there devils2ndself! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@kristi-dev
Copy link
Contributor

kristi-dev commented Oct 24, 2022

Hey, Artem. Could you, please, put an "x" next to all items below the Checklist, otherwise the build will fail

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
My changes generate no new warnings (e.g. Sonar is happy)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged

@workshur workshur requested a review from Haarolean October 24, 2022 10:43
@workshur
Copy link
Member

@Haarolean pls take a look 👀

@Haarolean Haarolean added type/bug Something isn't working scope/frontend labels Oct 24, 2022
@Haarolean Haarolean requested a review from a team October 24, 2022 19:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@BulatKha BulatKha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found issue:
KSQL: Container with query "Status" is too narrow #2822

@devils2ndself
Copy link
Contributor Author

Found issue: KSQL: Container with query "Status" is too narrow #2822

is it something caused by my changes?

@Haarolean
Copy link
Contributor

Found issue: KSQL: Container with query "Status" is too narrow #2822

is it something caused by my changes?

dw, we'll do this in a separate one, not sure that's (quickly) fixable. Thanks for the contribution!

@Haarolean Haarolean merged commit a123801 into provectus:master Oct 25, 2022
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Narekmat pushed a commit that referenced this pull request Dec 12, 2022
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KSQL: "Execute KSQL Request" Stream properties overlayed by KSQL query window
5 participants