-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: ksql request input overflow #2804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there devils2ndself! 👋
Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖
We will try to review it soon!
Hey, Artem. Could you, please, put an "x" next to all items below the Checklist, otherwise the build will fail
|
@Haarolean pls take a look 👀 |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found issue:
KSQL: Container with query "Status" is too narrow #2822
is it something caused by my changes? |
dw, we'll do this in a separate one, not sure that's (quickly) fixable. Thanks for the contribution! |
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Co-authored-by: Roman Zabaluev <rzabaluev@provectus.com>
Resolves #2721
What changes did you make? (Give an overview)
Made KSQL Request -> Stream Properties input tags responsive, resolving the overflow that was before.
Is there anything you'd like reviewers to focus on?
Maybe different resolutions. It worked fine at 1080p and was overflowing below 720p. Now should be working just fine at any resolution.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
