Skip to content

Fix a checksum exception about bazel-zig-cc. #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

lum1n0us
Copy link
Contributor

WARNING: Download from https://git.sr.ht/~motiejus/bazel-zig-cc/archive/v0.4.4.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was b3dd78971f0f831f62d84ae96656bdb0941b91b7c80097d69f5be213351cc6ff but wanted ad6384b4d16ebb3e5047df6548a195e598346da84e5f320250beb9198705ac81

@lum1n0us lum1n0us force-pushed the fix_bazel_zig_cc_checksum branch from 6eab25a to ce8fefd Compare March 27, 2023 01:48
Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lum1n0us lum1n0us force-pushed the fix_bazel_zig_cc_checksum branch from ce8fefd to d74210e Compare March 28, 2023 06:16
```
WARNING: Download from https://git.sr.ht/~motiejus/bazel-zig-cc/archive/v0.4.4.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException Checksum was b3dd78971f0f831f62d84ae96656bdb0941b91b7c80097d69f5be213351cc6ff but wanted ad6384b4d16ebb3e5047df6548a195e598346da84e5f320250beb9198705ac81
```

Signed-off-by: liang.he@intel.com <liang.he@intel.com>
@lum1n0us lum1n0us force-pushed the fix_bazel_zig_cc_checksum branch from d74210e to 0d6bc8b Compare March 28, 2023 06:28
@PiotrSikora
Copy link
Member

Any chance to update it to latest version while you're at it? Assuming it's a simple version bump.

@lum1n0us
Copy link
Contributor Author

like v1.0.1?

@PiotrSikora
Copy link
Member

Yes.

@lum1n0us
Copy link
Contributor Author

met an error likes:

	File "/home/runner/.cache/bazel/_bazel_runner/ae21fb6b2e26a9267f16b46bb90ea321/external/proxy_wasm_cpp_host/bazel/dependencies.bzl", line 15, column 70, in <toplevel>
		load("@bazel-zig-cc//toolchain:defs.bzl", zig_register_toolchains = "register_toolchains")
Error: file '@bazel-zig-cc//toolchain:defs.bzl' does not contain symbol 'register_toolchains'
ERROR: error loading package '': initialization of module 'bazel/dependencies.bzl' failed

Does it suggest that we should use load("@bazel-zig-cc//toolchain:defs.bzl", zig_register_toolchains = "toolchains") to replace load("@bazel-zig-cc//toolchain:defs.bzl", zig_register_toolchains = "register_toolchains") in bazel/dependencies.bzl ?

@PiotrSikora
Copy link
Member

Does it suggest that we should use load("@bazel-zig-cc//toolchain:defs.bzl", zig_register_toolchains = "toolchains") to replace load("@bazel-zig-cc//toolchain:defs.bzl", zig_register_toolchains = "register_toolchains") in bazel/dependencies.bzl ?

Correct.

You could also follow the official example and use:

load("@bazel-zig-cc//toolchain:defs.bzl", zig_toolchains = "toolchains")

and replace zig_register_toolchains with zig_toolchains later in the rules.

@PiotrSikora
Copy link
Member

Could you fix DCO (Signed-off-by is missing in the last commit)?

@lum1n0us lum1n0us force-pushed the fix_bazel_zig_cc_checksum branch from 861366a to 5ee8b49 Compare March 28, 2023 08:01
@lum1n0us lum1n0us force-pushed the fix_bazel_zig_cc_checksum branch from 5ee8b49 to 0d6bc8b Compare March 28, 2023 23:43
@PiotrSikora PiotrSikora changed the title Fix a checksum exception about bazel-zig-cc Fix a checksum exception about bazel-zig-cc. Mar 29, 2023
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora requested a review from mathetake March 29, 2023 00:45
@mathetake mathetake merged commit 3af2c1a into proxy-wasm:master Mar 29, 2023
@lum1n0us lum1n0us deleted the fix_bazel_zig_cc_checksum branch March 29, 2023 00:55
johnlanni pushed a commit to higress-group/proxy-wasm-cpp-host that referenced this pull request Mar 25, 2025
Signed-off-by: liang.he@intel.com <liang.he@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants