-
Notifications
You must be signed in to change notification settings - Fork 76
Feat: Support creating warmed VM in the proxy wasm V8 VM API. #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
Looks like you need to add no-op implementations of |
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
FYI, there is already an open PR with support for warming VMs (including other engines and tests): #280 |
Thanks for pointing that out! I'd forgotten that existed. Looking at the two PR's I'd propose that we combine them together and "do both". As you point out, the benefit of #280 is that it provides init*Engine() impls for all engines. However, it does not instantiate So how about we combine the two PRs:
@rachgreen33 LMK if you'd like me to create a PR that does this, or if you'd prefer to update this one yourself. Thanks! |
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
Signed-off-by: Rachel Green <rachgreen@google.com>
No description provided.