Skip to content

Conversation

Xunzhuo
Copy link
Contributor

@Xunzhuo Xunzhuo commented Apr 12, 2021

make readme read friendly

@bianpengyuan
Copy link
Contributor

@Xunzhuo Thanks for your contribution! Please sign your PR and make DCO happy. Thanks! https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/100/checks?check_run_id=2320395400

Signed-off-by: bitliu <mixdeers@gmail.com>
@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented Apr 13, 2021

@Xunzhuo Thanks for your contribution! Please sign your PR and make DCO happy. Thanks! https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/pull/100/checks?check_run_id=2320395400

Sure Everything is OK now, please take a look~😀

@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented Apr 13, 2021

@PiotrSikora Please take a look~ Thanks😀

@PiotrSikora
Copy link
Member

@Xunzhuo While you're at it, could you add language identifiers to other code snippets? There are a few bash and makefile snippets that are missing them. Thanks!

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo
Copy link
Contributor Author

Xunzhuo commented Apr 13, 2021

@PiotrSikora Sure~ Everything is ok now~ Please take a look😊

@PiotrSikora PiotrSikora changed the title beautify cpp code Beautify code snippets. Apr 13, 2021
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit b2e6b07 into proxy-wasm:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants