Skip to content

fix sendLocalResponse unable to update headers #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2020
Merged

fix sendLocalResponse unable to update headers #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
937fac0
fix sendLocalResponse
Masterlvng Jul 20, 2020
abcdbc5
Merge branch 'master' into fix-sendLocalResponse2
jplevyak Aug 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions proxy_wasm_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ template <typename Pairs> void exportPairs(const Pairs &pairs, const char **ptr,
char *buffer = static_cast<char *>(::malloc(size));
marshalPairs(pairs, buffer);
*size_ptr = size;
*ptr = buffer;
}

struct PairHash {
Expand Down Expand Up @@ -609,9 +610,11 @@ inline WasmResult sendLocalResponse(uint32_t response_code, std::string_view res
const char *ptr = nullptr;
size_t size = 0;
exportPairs(additional_response_headers, &ptr, &size);
return proxy_send_local_response(response_code, response_code_details.data(),
response_code_details.size(), body.data(), body.size(), ptr,
size, static_cast<uint32_t>(grpc_status));
WasmResult result = proxy_send_local_response(
response_code, response_code_details.data(), response_code_details.size(), body.data(),
body.size(), ptr, size, static_cast<uint32_t>(grpc_status));
::free(const_cast<char *>(ptr));
return result;
}

// SharedData
Expand Down