Blacken .py files in blib2to3 #1011
Merged
+457
−319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the radio silence on this! I'm about to go on a trip for a week, but after that I can give more feedback and hopefully merge this PR in. I'm excited to get Black faster using mypyc. It would be good to make the tests less repetitive, but that can be a follow-up PR. |
msullivan
force-pushed
the
blacken-blib2to3
branch
from
77cdcf1 to
b81b66b
Compare
|
I've cleaned up the tests. CI is failing because of an issue found checking under mypy 0.730, which I put up #1039 to fix. |
This is in preparation for adding type annotations to blib2to3 in order to compiling it with mypyc (psf#1009, which I can rebase on top of this). To enforce that it stays blackened, I just cargo-culted the existing test code used for validating formatting. It feels pretty clunky now, though, so I can abstract the common logic out into a helper if that seems better. (But error messages might be less clear then?)
msullivan
force-pushed
the
blacken-blib2to3
branch
from
b81b66b to
3b3ce35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for adding type annotations to blib2to3 in
order to compiling it with mypyc (#1009, which I can rebase on top of
this).
To enforce that it stays blackened, I just cargo-culted the existing
test code used for validating formatting. It feels pretty clunky now,
though, so I can abstract the common logic out into a helper if that
seems better. (But error messages might be less clear then?)