-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parse_header_links on empty header #4245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4245 +/- ##
==========================================
+ Coverage 88.65% 88.66% +0.01%
==========================================
Files 18 18
Lines 2018 2021 +3
==========================================
+ Hits 1789 1792 +3
Misses 229 229
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, this is a good change! Can we get some tests and an entry in HISTORY.rst
please?
Sure thing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thank you so much!
Congratulations on your first Requests contribution! ✨🍰✨ |
You guys are very friendly. Thanks for the kind words. I'll try to patch the bogus server as well. |
When receiving an empty
Link:
header, one bogus entry was returned anyway. This breaks some applications.I agree that web servers shouldn't be sending those but they do so here we are. Also fixes docstring with proper return type.
Fixes halcy/Mastodon.py#74