This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Support for joins and converting arrays to queries.. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
commented
Dec 11, 2016
| @@ -36,6 +36,7 @@ public function supports(string $classFqn): bool | |||
| public function getCapabilities(): Capabilities | |||
| { | |||
| return Capabilities::create([ | |||
| 'can_join' => false, | |||
There was a problem hiding this comment.
Should be can_query_join ... ?
dantleech
commented
Dec 11, 2016
| @@ -0,0 +1,135 @@ | |||
| <?php | |||
|
|
|||
| namespace Psi\Component\ObjectAgent\Query\Converter; | |||
dantleech
force-pushed
the
select_join
branch
from
654f32a to
8a6159a
Compare
dantleech
commented
Dec 11, 2016
| $selects = []; | ||
| foreach ($query->getSelects() as $selectName => $selectAlias) { | ||
| $select = $selectName . ' ' . $selectAlias; | ||
| if (is_int($selectName)) { |
dantleech
force-pushed
the
select_join
branch
from
a600638 to
3b07a1a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.