Skip to content

Conversation

psolbach
Copy link
Owner

Exchanged generic User Agent string for recent GoogleBot. All tests pass – most of them are offline so we don't know how different sources react to the UA string yet. Can we update the tests to do remote/online fetching of all the sources in our fixtures?

cf => https://github.com/monperrus/crawler-user-agents/blob/master/crawler-user-agents.json

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.811% when pulling 22be1b9 on fix/consent-walls into 7bd1a01 on master.

@mborho mborho merged commit 381a02b into master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants