Skip to content

Add geo types support #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Aug 14, 2024
Merged

Conversation

Mernus
Copy link
Contributor

@Mernus Mernus commented Apr 9, 2024

Added geo types support from PostgreSQL and geo_types module in Rust.

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

AGAEV Denis E added 2 commits May 7, 2024 10:25
@chandr-andr
Copy link
Member

Btw. Looks great! Hope to see the final version soon!

@Mernus
Copy link
Contributor Author

Mernus commented May 13, 2024

Today will update on using exceptions that changed after main branch merge

@chandr-andr
Copy link
Member

Add tests, please

@Mernus
Copy link
Contributor Author

Mernus commented Jun 25, 2024

Added fixes, now all geo types except polygon are working well!
Have some troubles with writing polygon to databases, trying to figure out how to do it:

DriverError: Database engine exception: db error: ERROR: invalid number of points in external "polygon" value.

@chandr-andr chandr-andr merged commit cad337e into psqlpy-python:main Aug 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants