Feat: tag & upgrade & version & fastcommit #6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| v0.0.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| package chglogcmd | ||
|
|
||
| // https://github.com/goreleaser/chglog/blob/main/pkg/commands/format.go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package cmdutils | ||
|
|
||
| import ( | ||
| "sync" | ||
|
|
||
| "github.com/pubgo/fastcommit/configs" | ||
| "github.com/pubgo/fastcommit/utils" | ||
| "github.com/pubgo/funk/log" | ||
| ) | ||
|
|
||
| var GetBranchName = sync.OnceValue(func() string { return utils.GetCurrentBranch().Must() }) | ||
|
|
||
| func LoadConfigAndBranch() { | ||
| branchName := GetBranchName() | ||
| log.Info().Msg("current branch: " + branchName) | ||
| log.Info().Msg("config: " + configs.GetConfigPath()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| package configcmd | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/bitfield/script" | ||
| "github.com/pkg/browser" | ||
| "github.com/pubgo/fastcommit/configs" | ||
| "github.com/pubgo/funk/assert" | ||
| "github.com/pubgo/funk/log" | ||
| "github.com/pubgo/funk/recovery" | ||
| "github.com/urfave/cli/v3" | ||
| ) | ||
|
|
||
| func New() *cli.Command { | ||
| return &cli.Command{ | ||
| Name: "config", | ||
| Usage: "config management", | ||
| Action: func(ctx context.Context, command *cli.Command) error { | ||
| defer recovery.Exit() | ||
|
|
||
| cfgPath := configs.GetConfigPath() | ||
| log.Info().Msgf("config path: %s", cfgPath) | ||
|
|
||
| log.Info().Msgf("config data: \n%s", assert.Must1(os.ReadFile(cfgPath))) | ||
| return nil | ||
| }, | ||
| Commands: []*cli.Command{ | ||
| { | ||
| Name: "edit", | ||
| Usage: "fastcommit config edit [open|vim|zed|code|...]", | ||
| Action: func(ctx context.Context, command *cli.Command) error { | ||
| log.Info().Msgf("config path: %s", configs.GetConfigPath()) | ||
|
|
||
| if command.Args().Len() == 0 { | ||
| return browser.OpenFile(configs.GetConfigPath()) | ||
| } | ||
|
|
||
| cmd := command.Args().First() | ||
|
|
||
| path := assert.Exit1(filepath.Abs(configs.GetConfigPath())) | ||
| shell := fmt.Sprintf(`%s "%s"`, cmd, path) | ||
| log.Info().Msgf("edit config: %s", shell) | ||
| _, err := script.Exec(shell).Stdout() | ||
| return err | ||
|
Comment on lines
+45
to
+48
There was a problem hiding this comment. The way the shell command is constructed and executed is vulnerable to command injection. Since shell := fmt.Sprintf(`%s "%s"`, cmd, path)
log.Info().Msgf("edit config: %s", shell)
editorCmd := exec.CommandContext(ctx, cmd, path)
editorCmd.Stdin = os.Stdin
editorCmd.Stdout = os.Stdout
editorCmd.Stderr = os.Stderr
return editorCmd.Run() |
||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic overwrites the entire user configuration file with the default one if the version name in the config differs from the default. This is a destructive action that can lead to the loss of user-specific settings, such as their OpenAI API key or model preferences. A better approach would be to merge the configurations while preserving user settings, or at least to warn the user and ask for confirmation before overwriting the file. I suggest replacing this with a non-destructive warning.