forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test cli steps parsing #1833
Draft
daemon1024
wants to merge
4
commits into
main
Choose a base branch
from
daemon1024/cli-test-suite-1747
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
test cli steps parsing #1833
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f6949c9
make utility to read stdout and stderr
daemon1024 73b4937
test cli steps parsing
daemon1024 a8ae036
Merge branch 'main' into daemon1024/cli-test-suite-1747
jywarren f5a6cea
modify read log util and make a single test pass by adding blocking code
daemon1024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
const test = require('tape'); | ||
const cli = require('../../src/cli'); | ||
const stdout = require('./util/readConsole').stdout; | ||
const stderr = require('./util/readConsole').stderr; | ||
|
||
function sleep(ms) { | ||
return new Promise(resolve => setTimeout(resolve, ms)); | ||
} | ||
|
||
test('testing steps parsing', function (t) { | ||
|
||
t.plan(1); | ||
|
||
let out = stdout.read(); | ||
|
||
cli([ | ||
'node', 'test', | ||
'-i', 'examples/images/test.png', | ||
'-s', 'invert', | ||
]); | ||
|
||
sleep(1000).then(() => { | ||
out.restore(); | ||
let validator = out.output().includes('Added Step "invert"'); | ||
t.true(validator, 'Steps parsed successfully'); | ||
}); | ||
|
||
|
||
// let err = stderr.read(); | ||
// await cli([ | ||
// 'node', 'test', | ||
// '-i', 'examples/images/test.png', | ||
// '-s', 'invalidStep', | ||
// ]); | ||
// err.restore(); | ||
// t.equal(err.output, 'Please ensure all steps are valid.'); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
function ReadLog(stream) { | ||
this._stream = stream; | ||
} | ||
|
||
ReadLog.prototype.read = function(options) { | ||
|
||
let output = ''; | ||
let stream = this._stream; | ||
|
||
let originalStreamWrite = stream.write; | ||
stream.write = function(string) { | ||
output += string; | ||
}; | ||
|
||
return { | ||
output: function () { | ||
return output; | ||
}, | ||
restore: function() { | ||
stream.write = originalStreamWrite; | ||
} | ||
}; | ||
}; | ||
|
||
exports.stdout = new ReadLog(process.stdout); | ||
exports.stderr = new ReadLog(process.stderr); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks ok, compared to
image-sequencer/test/cli/saveSequence.js
Lines 1 to 2 in 3b8181a