Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Image Sequencer Demo #92

Merged
merged 49 commits into from
Aug 21, 2017
Merged

Added Image Sequencer Demo #92

merged 49 commits into from
Aug 21, 2017

Conversation

ccpandhare
Copy link
Collaborator

Hey, I made a makup, and I'd want you to have a look at it. This is just marup - non functional.

https://ccpandhare.github.io/image-sequencer/examples

@ccpandhare
Copy link
Collaborator Author

umm , no
the "key" is a placeholder

@ccpandhare
Copy link
Collaborator Author

It will hold the name of the actual input, please check out the demo,
https://ccpandhare.github.io/image-sequencer/examples
I have already implemented it :-)

@jywarren
Copy link
Member

Super, just catching up. I know we're talking about the same thing, but I'm not sure we're seeing the same thing; is this right?

@jywarren
Copy link
Member

screenshot_20170820-104838

@ccpandhare
Copy link
Collaborator Author

I am very sorry, I must've pushed my changes to the demo branch and forgotten to publish the same to gh-pages :-(

I have updated it now

Screen Shot

@ccpandhare
Copy link
Collaborator Author

Does this look fine?

@jywarren
Copy link
Member

jywarren commented Aug 20, 2017 via email

@ccpandhare
Copy link
Collaborator Author

ccpandhare commented Aug 20, 2017 via email

@ccpandhare
Copy link
Collaborator Author

Let's have a final look at https://ccpandhare.github.io/image-sequencer/examples before merging this in!

@ccpandhare
Copy link
Collaborator Author

Also, I think the NPM Version can be bumped after this.

@ccpandhare
Copy link
Collaborator Author

This is how outputs are shown in the demo:
Screen Shot

Also, I have removed the test modules : "do-nothing" and "do-nothing-pix"

@ccpandhare
Copy link
Collaborator Author

I have now added comments to the demo HTML file. This will guide future users as to how a demo can be built. Updated CONTIBUTING.md about the output fields in info.json

@jywarren
Copy link
Member

jywarren commented Aug 21, 2017 via email

@ccpandhare
Copy link
Collaborator Author

Merging this in and will open a separate PR for #91

@ccpandhare ccpandhare merged commit 0fa0684 into publiclab:master Aug 21, 2017
@jywarren
Copy link
Member

jywarren commented Aug 21, 2017 via email

@ccpandhare
Copy link
Collaborator Author

I have now added comments to the demo HTML file. This will guide future users as to how a demo can be built. Updated CONTIBUTING.md about the output fields in info.json

-- Sorry this should have been posted earlier; posting this just for the sake of ompleteness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants