-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border to Authors in gallery template #965 #966
Conversation
First Timers is awesome! Added a border for issue publiclab#965
Thanks for opening this pull request! |
Code Climate has analyzed commit a42e567 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
==========================================
- Coverage 73.15% 72.78% -0.37%
==========================================
Files 37 37
Lines 1356 1356
==========================================
- Hits 992 987 -5
- Misses 364 369 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It Looks Good 🎉 🎉 🎉
Can you please upload the screenshot of the change?
Thank you!
thanks @divyabaid16 ! So excited that I was able to do this. Attached is the screenshot. |
Oh!! Actually, I meant you to upload the screenshot of the change that code corresponds to @sirnickyc |
Do you need any help @nickycutesc ? |
Hey Divya,
Sorry about the late response! So what would the screenshot entail? Do you have any sample screenshots for earlier issues that I can reference?
Thanks,
Nick
… On Sep 10, 2019, at 1:43 AM, Divya Baid ***@***.***> wrote:
Do you need any help @nickycutesc ?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@nickycutesc The screenshot should show how the UI should look after you have made the changes. |
So I would need to download the application in order to show this screenshot, correct? |
Yes!! |
Ok, great I'll get to that later in the week. |
Okay, that's great @nickycutesc ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickycutesc well done!
@divyabaid16 here is the screenshot: |
Okay, great. |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Awesome, thank you!!! |
Hey FirstTimers, thanks so much for this opportunity and for the invitation to PublicLab! My Twitter handle is: @nickycutesc |
First Timers is awesome! Added a border for issue #965
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!