Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to Authors in gallery template #965 #966

Merged
merged 1 commit into from Jan 13, 2020

Conversation

porcupinenick
Copy link
Contributor

First Timers is awesome! Added a border for issue #965

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

First Timers is awesome! Added a border for issue publiclab#965
@welcome
Copy link

welcome bot commented Aug 25, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2019

Code Climate has analyzed commit a42e567 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 25, 2019

Codecov Report

Merging #966 into main will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   73.15%   72.78%   -0.37%     
==========================================
  Files          37       37              
  Lines        1356     1356              
==========================================
- Hits          992      987       -5     
- Misses        364      369       +5
Impacted Files Coverage Δ
lib/exporter.rb 91.92% <0%> (-2.25%) ⬇️

Copy link
Contributor

@divyabaid16 divyabaid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Looks Good 🎉 🎉 🎉
Can you please upload the screenshot of the change?
Thank you!

@porcupinenick
Copy link
Contributor Author

thanks @divyabaid16 ! So excited that I was able to do this. Attached is the screenshot.

IMG_2862

@divyabaid16
Copy link
Contributor

Oh!! Actually, I meant you to upload the screenshot of the change that code corresponds to @sirnickyc

@divyabaid16
Copy link
Contributor

Do you need any help @nickycutesc ?
Thanks!

@porcupinenick
Copy link
Contributor Author

porcupinenick commented Sep 10, 2019 via email

@divyabaid16
Copy link
Contributor

@nickycutesc The screenshot should show how the UI should look after you have made the changes.

@porcupinenick
Copy link
Contributor Author

So I would need to download the application in order to show this screenshot, correct?

@divyabaid16
Copy link
Contributor

Yes!!

@porcupinenick
Copy link
Contributor Author

Ok, great I'll get to that later in the week.

@divyabaid16
Copy link
Contributor

Okay, that's great @nickycutesc !

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickycutesc well done!

@VladimirMikulic
Copy link
Contributor

@divyabaid16 here is the screenshot:

Screenshot_20200110_042910

@divyabaid16
Copy link
Contributor

Okay, great.

@jywarren jywarren merged commit 9d13373 into publiclab:main Jan 13, 2020
@welcome
Copy link

welcome bot commented Jan 13, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Awesome, thank you!!!

@porcupinenick
Copy link
Contributor Author

porcupinenick commented Jan 13, 2020

Hey FirstTimers, thanks so much for this opportunity and for the invitation to PublicLab! My Twitter handle is: @nickycutesc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants