-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new autocompletion code from PublicLab.Editor #4798
Comments
@rexagod just so you see this here too! |
Hey @jywarren , is somebody working on this issue ? |
This would be great and I think there may be some work to be done on the
editor project first to standardize how it's connected up. Maybe @rexagod
can offer some input?
…On Wed, Feb 20, 2019, 6:33 AM Vlad ***@***.*** wrote:
Hey @jywarren <https://github.com/jywarren> , is somebody working on this
issue ?
I would like to help with this one. How could I start ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4798 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwJRayGJ1I4d1l53f-giIUajQK2Iks5vPVyogaJpZM4a6Vha>
.
|
Hey @vladdypwnz! You can start by commenting out both of the lines mentioned above. Then we can continue this here. @jywarren After documenting |
Awesome, thanks both of you!!
…On Wed, Feb 20, 2019, 1:09 PM Pranshu Srivastava ***@***.*** wrote:
Hey @vladdypwnz <https://github.com/vladdypwnz>! You can start by commenting
out
<publiclab/PublicLab.Editor#55 (comment)>
both of the lines mentioned above. Then we can continue on this here
<publiclab/PublicLab.Editor#55 (comment)>
.
@jywarren <https://github.com/jywarren> After documenting atwho in the
README, I'll focus on implementing publiclab/PublicLab.Editor#55 (comment)
<publiclab/PublicLab.Editor#55 (comment)>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4798 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJw2pzv2kLqDI-JKg6JxwdxPzcDfCks5vPblggaJpZM4a6Vha>
.
|
Hi @jywarren |
This code is now out of date:
plots2/app/views/editor/rich.html.erb
Lines 326 to 327 in fe50428
We have a great new autocompletion system in the Editor project, and are working on documenting/refining it here: publiclab/PublicLab.Editor#55
This should allow autocompletion of
@usernames
,#tags
, and:emoji:
using the At.js library. A few more steps to complete the integration but this will be great! Any help appreciated both completing publiclab/PublicLab.Editor#55 and here once that is complete.The text was updated successfully, but these errors were encountered: