Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include one-line outreach-oriented note in email footers #932

Closed
jywarren opened this issue Oct 30, 2016 · 18 comments
Closed

Include one-line outreach-oriented note in email footers #932

jywarren opened this issue Oct 30, 2016 · 18 comments
Labels
enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute outreach issues involve community involvement and helping people who're stuck somewhere Ruby

Comments

@jywarren
Copy link
Member

Currently, emails look something like (depending on if they're questions, comments, notes, etc):

Hi! There's been a new answer posted for the question 'Can we use a timelapse or video camera to monitor particulate air plumes?' that you liked. Do NOT reply to this email; click this link to see the answer:
https://publiclab.org/questions/gretchengehrke/09-20-2016/question-would-it-be-feasible-to-use-a-stationary-camera-to-conduct-emissions-opacity-evaluation#a105

Here is the answer that gretchengehrke wrote:

It turns out that Alternative Method 82 is pretty strict in its procedure, so timelapse and video cameras wouldn't be able to explicitly do that method, but I think they could probably prompt an inspection. Anyway, I recently learned a lot more about EPA Method 9, and some more about Alternative Method 82, and wrote a blog post about it: https://publiclab.org/notes/gretchengehrke/10-28-2016/colorado-regulations-hotsheet

You can comment on the answer at: https://publiclab.org/questions/gretchengehrke/09-20-2016/question-would-it-be-feasible-to-use-a-stationary-camera-to-conduct-emissions-opacity-evaluation#answer-105-comment

Report abuse to: moderators@publiclab.org

A typical email (for a new note) is generated here: https://github.com/publiclab/plots2/blob/master/app/views/subscription_mailer/notify_node_creation.html.erb

We could include a line at the bottom using the Features system, using the feature() helper:

<% cache('feature_email-footer') do %> // <== this caches and uses a cached version of the feature, which is expired when the feature is edited
  <%= feature('email-footer') %>
<% end %>

Then the actual text could be set using the features system -- available to admins at /features.

@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features outreach issues involve community involvement and helping people who're stuck somewhere help wanted requires help by anyone willing to contribute Ruby fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Oct 30, 2016
@ykl7
Copy link
Member

ykl7 commented Oct 31, 2016

@jywarren mind if i take this one?

@jywarren
Copy link
Member Author

That would be great, but we may be waiting on a fix from the library that
would generate this...

On Oct 30, 2016 9:25 PM, "ykl7" notifications@github.com wrote:

@jywarren https://github.com/jywarren mind if i take this one?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#932 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ20C3Okv_d1b6wZJ4_Wjf1V8eAdiks5q5W3EgaJpZM4KkdiP
.

@ykl7
Copy link
Member

ykl7 commented Oct 31, 2016

I could wait for the library fix if needed. If it is not resolved, I'll look into it.

@jywarren
Copy link
Member Author

OK -- I'd like to use the library, as manually including names could be
quite onerous every time we publish. Thanks, and if you're looking for a
challenge in the meantime, I've added some new help-wanted issues.

On Sun, Oct 30, 2016 at 9:35 PM, ykl7 notifications@github.com wrote:

I could wait for the library fix if needed. If it is not resolved, I'll
look into it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#932 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2Tk_tlSW0QYyOy_T5rcIDKiLxkRks5q5XAigaJpZM4KkdiP
.

@ykl7
Copy link
Member

ykl7 commented Oct 31, 2016

That sounds good

@ryzokuken
Copy link
Member

@ykl7 Still working on it?

@ykl7
Copy link
Member

ykl7 commented Nov 4, 2016

@ryzokuken I was told to wait for a library fix by @jywarren . If that fix doesn't work, I'll do it, but no word yet.

@ryzokuken
Copy link
Member

okay, cool.

@jywarren
Copy link
Member Author

jywarren commented Nov 4, 2016

Hi, all -- the issue, in case you want to take a crack at it, is this one: mntnr/name-your-contributors#15

If we can get that to work, I think we can move forward with this!

@jywarren
Copy link
Member Author

jywarren commented Nov 4, 2016

Ack, apologies, I'd mixed up two issues!!! #931 depends on name-your contributors, not this. This is ready to be worked on, @ykl7 -- apologies for the mixup! I'm looking at too many issues these days with all of your excellent contributions coming in so fast! :-)

@ryzokuken
Copy link
Member

No worries, @jywarren 😁

Keep up the good work!

@ykl7
Copy link
Member

ykl7 commented Nov 4, 2016

@jywarren I'll try to get this done over the weekend and send a PR as soon as possible

@ykl7
Copy link
Member

ykl7 commented Nov 6, 2016

@jywarren Does this have to be added at the bottom of each email sent or will it be just for a new note creation?

@jywarren
Copy link
Member Author

jywarren commented Nov 8, 2016

I think we could do it for all emails, thanks!

On Nov 6, 2016 6:41 AM, "ykl7" notifications@github.com wrote:

@jywarren https://github.com/jywarren Does this have to be added at the
bottom of each email sent or will it be just for a new note creation?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#932 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ-Gl1MIwFZ1BS17oPglUdGAwZZ0mks5q7bzXgaJpZM4KkdiP
.

@jywarren
Copy link
Member Author

Hello -- how's this going? We could definitely start with just one email, to confirm that it works, then open a new issue to build on your first step. How does that sound?

@ykl7
Copy link
Member

ykl7 commented Nov 23, 2016

That sounds good, I was trying to do the same in the last PR I opened, to get one working then work on the rest.

@jywarren
Copy link
Member Author

jywarren commented Dec 7, 2016 via email

@jywarren
Copy link
Member Author

jywarren commented Dec 7, 2016

Do you think you'd be interested in this somewhat related issue? #931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute outreach issues involve community involvement and helping people who're stuck somewhere Ruby
Projects
None yet
Development

No branches or pull requests

3 participants