-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include one-line outreach-oriented note in email footers #932
Comments
@jywarren mind if i take this one? |
That would be great, but we may be waiting on a fix from the library that On Oct 30, 2016 9:25 PM, "ykl7" notifications@github.com wrote:
|
I could wait for the library fix if needed. If it is not resolved, I'll look into it. |
OK -- I'd like to use the library, as manually including names could be On Sun, Oct 30, 2016 at 9:35 PM, ykl7 notifications@github.com wrote:
|
That sounds good |
@ykl7 Still working on it? |
@ryzokuken I was told to wait for a library fix by @jywarren . If that fix doesn't work, I'll do it, but no word yet. |
okay, cool. |
Hi, all -- the issue, in case you want to take a crack at it, is this one: mntnr/name-your-contributors#15 If we can get that to work, I think we can move forward with this! |
No worries, @jywarren 😁 Keep up the good work! |
@jywarren I'll try to get this done over the weekend and send a PR as soon as possible |
@jywarren Does this have to be added at the bottom of each email sent or will it be just for a new note creation? |
I think we could do it for all emails, thanks! On Nov 6, 2016 6:41 AM, "ykl7" notifications@github.com wrote:
|
Hello -- how's this going? We could definitely start with just one email, to confirm that it works, then open a new issue to build on your first step. How does that sound? |
That sounds good, I was trying to do the same in the last PR I opened, to get one working then work on the rest. |
:-) super rad!
…On Wed, Dec 7, 2016 at 2:31 PM, ykl7 ***@***.***> wrote:
Closed #932 <#932>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#932 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0RWIOoktegccISlaTqL8lZ1Vk_5ks5rFwmKgaJpZM4KkdiP>
.
|
Do you think you'd be interested in this somewhat related issue? #931 |
Currently, emails look something like (depending on if they're questions, comments, notes, etc):
A typical email (for a new note) is generated here: https://github.com/publiclab/plots2/blob/master/app/views/subscription_mailer/notify_node_creation.html.erb
We could include a line at the bottom using the Features system, using the
feature()
helper:Then the actual text could be set using the features system -- available to admins at
/features
.The text was updated successfully, but these errors were encountered: