Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor images shortlink #9898

Closed
5 tasks
cesswairimu opened this issue Jul 10, 2021 · 3 comments · Fixed by #9900
Closed
5 tasks

refactor images shortlink #9898

cesswairimu opened this issue Jul 10, 2021 · 3 comments · Fixed by #9900
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@cesswairimu
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

See this page for some help in taking your first steps!

On this method https://github.com/publiclab/plots2/blob/main/app/controllers/images_controller.rb#L7-L17
replace line 8 with size = params[:size] || params[:s]
And then replace every instance of params[:size] with size .

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@cesswairimu cesswairimu added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Jul 10, 2021
@cesswairimu
Copy link
Collaborator Author

Reserved for @saraswathy-krish

@saraswathy-krish
Copy link
Contributor

Hello @cesswairimu , Thank you, I will start working on this.

saraswathy-krish added a commit to saraswathy-krish/plots2 that referenced this issue Jul 11, 2021
@saraswathy-krish
Copy link
Contributor

Hi @cesswairimu I have created a pull request for the same. Kindly let me know in case of any issues.
Thanks again for helping me out!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants