Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 2 initial/incorrect 'g's from webpacker commands in Github Actions #10138

Closed
wants to merge 1 commit into from

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Sep 7, 2021

re: #9502

@gitpod-io
Copy link

gitpod-io bot commented Sep 7, 2021

@codeclimate
Copy link

codeclimate bot commented Sep 7, 2021

Code Climate has analyzed commit 9b28fe5 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren jywarren changed the title remove 2 initial/incorrect 'g's from webpacker commands remove 2 initial/incorrect 'g's from webpacker commands in Github Actions Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #10138 (9b28fe5) into main (f41f8e7) will decrease coverage by 0.02%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10138      +/-   ##
==========================================
- Coverage   82.13%   82.11%   -0.03%     
==========================================
  Files          98       98              
  Lines        5968     5977       +9     
==========================================
+ Hits         4902     4908       +6     
- Misses       1066     1069       +3     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/tag_controller.rb 80.42% <50.00%> (ø)
app/controllers/home_controller.rb 96.05% <100.00%> (-2.62%) ⬇️
app/controllers/images_controller.rb 72.50% <100.00%> (+2.22%) ⬆️
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/models/image.rb 82.05% <100.00%> (-0.45%) ⬇️
app/models/user.rb 86.12% <100.00%> (ø)
app/services/search_service.rb 94.89% <100.00%> (-0.21%) ⬇️
... and 5 more

@noi5e
Copy link
Contributor

noi5e commented Sep 7, 2021

Showing this error now, which I believe is unrelated?
Screen Shot 2021-09-07 at 10 47 52 AM

Going to close and reopen to run tests again.

@noi5e noi5e closed this Sep 7, 2021
@noi5e noi5e reopened this Sep 7, 2021
@noi5e noi5e closed this Sep 12, 2021
@noi5e noi5e reopened this Sep 12, 2021
@jywarren
Copy link
Member Author

Showing this error now, which I believe is unrelated?

Yeah i got that too in #10137 -- frustrating. I'll open an issue.

@jywarren
Copy link
Member Author

We might fix #10137 before fixing this...

@jywarren
Copy link
Member Author

Perfect. This worked. Merging!!

@jywarren jywarren closed this Sep 21, 2021
@jywarren
Copy link
Member Author

#10137 succeeded!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants