Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated en.yml and dashboard.html.erb #11113

Closed
wants to merge 1 commit into from

Conversation

willmelton21
Copy link

made the requested changes to app/views/dashboard/dashboard.html.erb and config/locales/en.yml

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

made the requested changes to app/views/dashboard/dashboard.html.erb and config/locales/en.yml
@gitpod-io
Copy link

gitpod-io bot commented May 2, 2022

@codeclimate
Copy link

codeclimate bot commented May 2, 2022

Code Climate has analyzed commit c075d53 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #11113 (c075d53) into main (b7c28f9) will decrease coverage by 80.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #11113       +/-   ##
===========================================
- Coverage   82.45%    1.77%   -80.69%     
===========================================
  Files          98       98               
  Lines        5990     8963     +2973     
===========================================
- Hits         4939      159     -4780     
- Misses       1051     8804     +7753     
Impacted Files Coverage Δ
app/models/like.rb 0.00% <0.00%> (-100.00%) ⬇️
lib/text_search.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/csvfile.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/node_tag.rb 0.00% <0.00%> (-100.00%) ⬇️
app/models/user_tag.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/map_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/tag_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/home_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/helpers/wiki_helper.rb 0.00% <0.00%> (-100.00%) ⬇️
app/mailers/node_mailer.rb 0.00% <0.00%> (-100.00%) ⬇️
... and 82 more

description: "This is your dashboard, where recent updates from other community members show up. It'll keep you updated with recent progress, news and developments."
get_started: "To get started at Public Lab, try:"
ask_question: "Asking a question"
explore_projects: "Exploring projects"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @willmelton21, can you indent lines 346-350 by two spaces? Thank you!!

@TildaDares
Copy link
Member

Could you also add the issue number in the description above? Thanks!!

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@TildaDares
Copy link
Member

Hi @willmelton21, do you need any assistance with this? Please feel free to reach out if you do.

@TildaDares
Copy link
Member

TildaDares commented Jun 2, 2022

Thank you for taking the time to work on this PR but the issue has been resolved in #11151. If you'd like to work on another issue, please leave a comment in #11105 and we'll look for another one for you.

@TildaDares TildaDares closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants