Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list.html.erb #11358

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Update list.html.erb #11358

merged 2 commits into from
Aug 30, 2022

Conversation

Beckeruni
Copy link
Contributor

@Beckeruni Beckeruni commented Aug 21, 2022

Fixes #11357

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@Beckeruni Beckeruni requested a review from a team as a code owner August 21, 2022 10:13
@welcome
Copy link

welcome bot commented Aug 21, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Aug 21, 2022

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #11358 (9c87053) into main (4f3503d) will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11358      +/-   ##
==========================================
+ Coverage   81.38%   82.46%   +1.07%     
==========================================
  Files          98       98              
  Lines        5996     5998       +2     
==========================================
+ Hits         4880     4946      +66     
+ Misses       1116     1052      -64     
Impacted Files Coverage Δ
app/models/node.rb 91.12% <0.00%> (+0.16%) ⬆️
app/controllers/comment_controller.rb 83.07% <0.00%> (+0.26%) ⬆️
app/controllers/users_controller.rb 80.78% <0.00%> (+0.35%) ⬆️
app/api/srch/search.rb 70.51% <0.00%> (+0.64%) ⬆️
app/controllers/spam2_controller.rb 71.84% <0.00%> (+0.97%) ⬆️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️
app/controllers/admin_controller.rb 80.24% <0.00%> (+1.64%) ⬆️
app/helpers/application_helper.rb 88.65% <0.00%> (+2.06%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+3.39%) ⬆️
... and 4 more

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/7907789070/artifacts/336576623

@TildaDares
Copy link
Member

Hi @Beckeruni, can you add a link to the issue? Thank you!

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

Copy link
Contributor Author

@Beckeruni Beckeruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original link: #11357

<li class="btn-success"><a style="color: white;" href="/profile/<%= user.username %>"><i class="fa fa-check-circle fa-white"></i> Unban on profile</a></li>
<i class='fa fa-ban' style="color:#a00;"></i> <%= translation('users.list.banned') %>
<li class="btn-success m-2" style="border-radius: 2px;"><a class="p-1 text-center w-100" style="color: white;" href="/profile/<%= user.username %>"><i class="fa fa-check-circle fa-white"></i> Unban on profile</a></li>
+ <p class="text-center m-0"><i class='fa fa-ban' style="color:#a00;"></i> <%= translation('users.list.banned') %></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Beckeruni, seems you added unwanted + at the beginning of this line. Kindly check. Everything else looks good.
Thanks for working on this

deleted unwanted  '+'
@codeclimate
Copy link

codeclimate bot commented Aug 22, 2022

Code Climate has analyzed commit 9c87053 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/7917680695/artifacts/337278824

@TildaDares
Copy link
Member

Hi @Beckeruni, do you need help with this? Please feel free to reach out if you do.

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Beckeruni!!

@TildaDares
Copy link
Member

@cesswairimu Is this ready to merge?

@cesswairimu
Copy link
Collaborator

yeah it is @TildaDares, thanks

@TildaDares TildaDares merged commit b97078c into publiclab:main Aug 30, 2022
@welcome
Copy link

welcome bot commented Aug 30, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

You can also join our Gitter channel to connect with other contributors 📥

@TildaDares
Copy link
Member

Congratulations on merging your PR @Beckeruni 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine Display of Unban Button
3 participants