-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list.html.erb #11358
Update list.html.erb #11358
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #11358 +/- ##
==========================================
+ Coverage 81.38% 82.46% +1.07%
==========================================
Files 98 98
Lines 5996 5998 +2
==========================================
+ Hits 4880 4946 +66
+ Misses 1116 1052 -64
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hi @Beckeruni, can you add a link to the issue? Thank you!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original link: #11357
app/views/users/list.html.erb
Outdated
<li class="btn-success"><a style="color: white;" href="/profile/<%= user.username %>"><i class="fa fa-check-circle fa-white"></i> Unban on profile</a></li> | ||
<i class='fa fa-ban' style="color:#a00;"></i> <%= translation('users.list.banned') %> | ||
<li class="btn-success m-2" style="border-radius: 2px;"><a class="p-1 text-center w-100" style="color: white;" href="/profile/<%= user.username %>"><i class="fa fa-check-circle fa-white"></i> Unban on profile</a></li> | ||
+ <p class="text-center m-0"><i class='fa fa-ban' style="color:#a00;"></i> <%= translation('users.list.banned') %></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Beckeruni, seems you added unwanted +
at the beginning of this line. Kindly check. Everything else looks good.
Thanks for working on this
deleted unwanted '+'
Code Climate has analyzed commit 9c87053 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hi @Beckeruni, do you need help with this? Please feel free to reach out if you do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @Beckeruni!!
@cesswairimu Is this ready to merge? |
yeah it is @TildaDares, thanks |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
Congratulations on merging your PR @Beckeruni 🎉 |
Fixes #11357
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below