Added pagination to limit the revisions of a wiki page #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namangupta01
force-pushed
the
display_revision
branch
from
298b1a0
to
cedef21
Compare
Generated by 🚫 Danger |
|
@jywarren Any idea how to test pagination ? |
jywarren
reviewed
May 10, 2018
| @@ -266,9 +266,10 @@ def revisions | |||
| @node = Node.find_wiki(params[:id]) | |||
| if @node | |||
| @revisions = @node.revisions | |||
| @revisions = @revisions.where(status: 1) unless current_user && current_user.can_moderate? | |||
| @revisions = @revisions.where(status: 1).page(params[:page]).per_page(20) unless current_user && current_user.can_moderate? | |||
There was a problem hiding this comment.
oh aha - so this unless condition turns off the pagination, right? So then we have to be sure not to treat the collection as paginated. You could add the same condition to line 272?
There was a problem hiding this comment.
Ohh! 😅 Ya you are right!
…evision Tab to 20
namangupta01
force-pushed
the
display_revision
branch
from
cedef21
to
b9fadb5
Compare
|
All test passed! |
|
SUPER!!!!!! This is great. @steviepubliclab will be happy - this solves the "zillion revisions" problem. |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
…evision Tab to 20 (publiclab#2707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2699
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!