Update docs and add tests for the taglocations API method - fix #3597

[stefannibrasil]

Fixes #3597

The API docs were showing a wrong param format for the taglocations endpoint. After investigating, I believe these changes attempt to fix that.

[plotsbot]

	1 Message
📖	@stefannibrasil Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[stefannibrasil]

@publiclab/reviewers @jywarren is that ok pass this codeclimate issue for later? I just added more validations to the method... or if you have any tips for this, would appreciate them. Thanks!

[jywarren]

Sure, passing it now! Thanks!

[jywarren]

One small tweak but THANK YOU this is much better!!! 🎉

[jywarren]

👍

[jywarren]

Also, sorry, I think you may have written this somewhere else but I'm a bit behind... is there a matching JS call which we have to tweak to conform to the .00 format?

[stefannibrasil]

hi, @jywarren thanks for the review!

I don't know about the JS call, to be honest. Was that already been done somewhere? I'm not aware...

[jywarren]

Ah, here:

plots2/app/views/map/_leaflet.html.erb

Line 37 in 79d65bf

$.getJSON("/api/srch/taglocations?query="+s , function(data){

Do we need to pad it or otherwise update it so it conforms to the API spec you've updated? Thanks!

[stefannibrasil]

oh, I see! thanks for the link, I'll check it out this week!

[jywarren]

Can't seem to get codeclimate to run, so gonna close and reopen!

Also, i changed the JS query I'd mentioned above -- here! #3940

[stefannibrasil]

hi, @jywarren thanks! I was going to take a look at it this holiday. Do you think this is ready, then? Thanks!

[jywarren]

Ah, i think we just have to preserve the blurred attribute as mentioned above, and then it's good to go. Thanks! #3700 (comment)

[jywarren]

I see the error:

ERROR["test_search_Tag_Nearby_Nodes_functionality_with_a_valid_query", #<Minitest::Reporters::Suite:0x000055902d927d00 @name="SearchApiTest">, 81.07464563299993]
 test_search_Tag_Nearby_Nodes_functionality_with_a_valid_query#SearchApiTest (81.07s)
NoMethodError:         NoMethodError: undefined method `blurred?' for #<Node:0x000055902d9d88f8>
            app/api/srch/search.rb:247:in `block (3 levels) in <class:Search>'

So, I think we need to add a blurred? method to nodes, like this one for users:

plots2/app/models/user.rb

Lines 206 to 208 in 788ff6f

	def blurred?
	has_power_tag("location") && get_value_of_power_tag("location") == 'blurred'
	end

I'll do that now.

[jywarren]

Cool, added that -- let's see: stefannibrasil@75724f3

[jywarren]

Yay!!!