reduced login redundancy #4605
Merged
reduced login redundancy #4605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide the 5 gifs with these changes. |
|
As a told you earlier. Provide the new gifs. |
|
@SidharthBansal Yes, Sorry for late reply .
|
SidharthBansal
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
Hi, changes looks good to me. Thanks for your work.
@jywarren can you please review this and merge this?
|
This is nicely done. Thanks a lot!!! |
jywarren
pushed a commit
that referenced
this pull request
Jan 17, 2019
* adding period to nearby nodes and people * codeclimate * codeclimate 2 * Multi Tag controller action now accepts lists also (#4606) * Multiple tag controller action accepts lists also now * Few minor changes * routes modified * User not logged in * minor change * Enhanced readability (#4610) * Enhanced readability * . * . * Username not editable in database (#4599) * making username not editable * making username not editable * making username not editable at database level * adding tests * editing test_1 * combining both tests * combining both tests * Multi tag subscription button (#4555) * Multiple subscriptions button version 2 * Fixes #4344 Multiple Tag subscription button * Removing comment * Changing same to tagnames * Partial for Subscribe Button * Keeping subscribed tags checked * Keeping 2 space indentation * params[:same] to params[:tagnames] * Fixing all indentation in tags_popover partial * Fixing indentation in tagging partial * Fixing more indentation in tags_popover partial * Login Modal now linked to Subscribe+ button * Login Modal now linked to Subscribe+ button * Delete _tags_pop.html.erb * Delete _tags.html.erb * Updating to return_to /login * Updating to return_to /login * Fixing indentation in tags_popover partial * Keeping subscribed tags checked revised code * Adding documentation to subscribe_button partial * Adding documentation to tagging partial * Fixing return to path * Fixing indentation once again * Fixing indentation once more * Modifying multiple_add function in subscription controller * attempting to untrack tags partial * Restoring original tags sidebar view * Removing trailing whitespace * Removing return statement at line 125 in susbcription controller * Update subscription_controller.rb * Update routes.rb * Update _tags_popover.html.erb * Update routes.rb * Update _tagging.html.erb * Removing space * reduced login redundancy (#4605) * reduced login redundancy * Revert "reduced login redundancy" This reverts commit 0ca2c7d. * changed new.html and header * moved partial content to file * Fixes #4311 optional profile picture at sign up (#4538) * Fixes #4311 optional profile picture at sign up * Fixing profile picture styling * Adding margin * OAuth status fix (#4618) * started with test * fix status on creation * Update user.rb * Update user_test.rb * Update user.rb * tests * test correction (#4621) * removing puts * adding period to nearby nodes and people * codeclimate * codeclimate 2 * Removing space * tests * removing puts * fixing tags order * more tests * codeclimate * codeclimate again * codeclimate again again * codeclimate again again again * fixing if condition * fixing if condition [2] * one more test
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* reduced login redundancy * Revert "reduced login redundancy" This reverts commit 0ca2c7d. * changed new.html and header * moved partial content to file
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* adding period to nearby nodes and people * codeclimate * codeclimate 2 * Multi Tag controller action now accepts lists also (publiclab#4606) * Multiple tag controller action accepts lists also now * Few minor changes * routes modified * User not logged in * minor change * Enhanced readability (publiclab#4610) * Enhanced readability * . * . * Username not editable in database (publiclab#4599) * making username not editable * making username not editable * making username not editable at database level * adding tests * editing test_1 * combining both tests * combining both tests * Multi tag subscription button (publiclab#4555) * Multiple subscriptions button version 2 * Fixes publiclab#4344 Multiple Tag subscription button * Removing comment * Changing same to tagnames * Partial for Subscribe Button * Keeping subscribed tags checked * Keeping 2 space indentation * params[:same] to params[:tagnames] * Fixing all indentation in tags_popover partial * Fixing indentation in tagging partial * Fixing more indentation in tags_popover partial * Login Modal now linked to Subscribe+ button * Login Modal now linked to Subscribe+ button * Delete _tags_pop.html.erb * Delete _tags.html.erb * Updating to return_to /login * Updating to return_to /login * Fixing indentation in tags_popover partial * Keeping subscribed tags checked revised code * Adding documentation to subscribe_button partial * Adding documentation to tagging partial * Fixing return to path * Fixing indentation once again * Fixing indentation once more * Modifying multiple_add function in subscription controller * attempting to untrack tags partial * Restoring original tags sidebar view * Removing trailing whitespace * Removing return statement at line 125 in susbcription controller * Update subscription_controller.rb * Update routes.rb * Update _tags_popover.html.erb * Update routes.rb * Update _tagging.html.erb * Removing space * reduced login redundancy (publiclab#4605) * reduced login redundancy * Revert "reduced login redundancy" This reverts commit 0ca2c7d. * changed new.html and header * moved partial content to file * Fixes publiclab#4311 optional profile picture at sign up (publiclab#4538) * Fixes publiclab#4311 optional profile picture at sign up * Fixing profile picture styling * Adding margin * OAuth status fix (publiclab#4618) * started with test * fix status on creation * Update user.rb * Update user_test.rb * Update user.rb * tests * test correction (publiclab#4621) * removing puts * adding period to nearby nodes and people * codeclimate * codeclimate 2 * Removing space * tests * removing puts * fixing tags order * more tests * codeclimate * codeclimate again * codeclimate again again * codeclimate again again again * fixing if condition * fixing if condition [2] * one more test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4456 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
updated PR version of #4580