Action cable integration tests for browser notification while posting comments #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namangupta01
added
summer-of-code
gsoc
testing
|
Hmm, what's stuck here, @namangupta01 ? |
|
Hi, is this ready to go? Thanks! |
|
Whoa, hm. Any relation to the error in
#6113 ?
I don't know - is anything non-deterministic? Could there be a timing issue
at stake, like not waiting long enough for a JS process to complete?
…On Sun, Aug 18, 2019 at 3:32 PM Naman Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Do you have an idea why system
test is failing in this pr and in #6153
<#6153>. System tests that are
failing in both the pr are different -- but both of them are updated with
the master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6030?email_source=notifications&email_token=AAAF6J477CDY3UC5AMQE56TQFGPRJA5CNFSM4IFRZVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RGREQ#issuecomment-522348690>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZY7ZDUWHV55PXRCHDQFGPRJANCNFSM4IFRZVFQ>
.
|
|
Finally, Test Passed! |
|
:-) Great!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6029