-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text overflow in people page #7572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7572 +/- ##
==========================================
+ Coverage 80.07% 81.90% +1.83%
==========================================
Files 97 97
Lines 5635 5615 -20
==========================================
+ Hits 4512 4599 +87
+ Misses 1123 1016 -107
|
@VladimirMikulic @jywarren can you kindly review? Thanks ✌️ |
Screenshots 📸 (click to expand)7572-test_questions.png7572-test_embeddable_grids.png7572-test_signup.png7572-test_viewing_the_settings_page.png7572-test_tag_by_author_page.png7572-failures_test_removing_tags_from_the_post.png7572-test_wiki_page_with_inline_grids.png7572-test_stats.png7572-test_viewing_the_dashboard.png7572-test_searching_an_item_from_the_homepage.png7572-test_signup_modal_form_validation.png7572-test_tag_stats.png7572-test_login_modal_form_validation.png7572-test_questions_shadow.png7572-test_login_modal.png7572-test_profile_page.png7572-test_comments.png7572-test_tags.png7572-test_signup_modal.png7572-test_wiki.png7572-failures_test_viewing_the_dashboard.png7572-test_methods.png7572-failures_test_pages_tagged_with_place_get_a_full-width_map_across_the_top_of_the_page.png7572-test_tag_page.png7572-test_blog_page_with_location_modal.png7572-test_tag_wildcard.png7572-test_signup_modal_disabled_submit_button_on_empty_username.png7572-test_embeddable_thumbnail_grids.png7572-failures_test_pages_not_tagged_with_place_gets_a_side_map.png7572-test_front_page_with_navbar_search_autocomplete.png7572-test_spam_moderation_page.png7572-test_login.png7572-test_viewing_the_dropdown_menu.png7572-test_viewing_question_post.png7572-test_mobile_displays.png7572-test_simple-data-grapher_powertag.png7572-test_front.png7572-test_question_page.png7572-test_tag_contributors_page.png7572-test_blog.png7572-test_people.png7572-test_wiki_revisions.pngLearn about automated screenshots Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Tlazypanda 🚀
@cesswairimu is this ready for a merge? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🎉
Fixes #7567
Fixed text username overflow in people page.
Before
After
rake test
@publiclab/reviewers
for help, in a comment belowThanks!