-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outreachy]Add Nearby Activity #9202
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9202 +/- ##
=======================================
Coverage ? 81.81%
=======================================
Files ? 100
Lines ? 5955
Branches ? 0
=======================================
Hits ? 4872
Misses ? 1083
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! Thanks Ruth!!!!!! 🎉
0d59750
to
ee399de
Compare
Investigating why the test is failing, not sure what is causing it... |
We should be able to fix this once publiclab/leaflet-environmental-layers#504 (comment) is merged -- instructions there! plots2/app/assets/javascripts/leafletHelper.js Lines 116 to 122 in 30fb696
is where the extra option This should resolve #5095 as well and we can close that! |
Thanks @jywarren 🎉 |
OK! I made the change in your branch, and now, i think we have to release a new version of LEL and wait for Dependabot to help us merge it in... or we could increment the version in this PR alternatively! |
OK, i'll do my best to publish this tonight or tomorrow and we'll watch for Dependabot!! |
Should happen from in publiclab/leaflet-environmental-layers#507 |
It'll be v2.4.2 of the |
yay!! #9208 |
125b7ba
to
96ed1a8
Compare
e618334
to
7f18bca
Compare
7f18bca
to
e8ef0bc
Compare
06e9f07
to
ed55a11
Compare
ed55a11
to
09cbda7
Compare
Hi @jywarren this is ready to merge... the owmloading.gif error was still happening with the system test I wrote... the error 'v2/owmloading.gif' kept happening with the test I wrote to ensure that subscribe tags do not show up in the trending tags section...I rewrote that test into a functional test and everything is working fine now... |
Code Climate has analyzed commit 4ca801c and detected 0 issues on this pull request. View more on Code Climate. |
That was really odd, it hadn't pulled in the latest changes from publiclab/plots2 main so I did that again... then ran Thanks Ruth, this should 🤞 pass and we can merge!!! |
🎉 🎉 |
Thanks @cesswairimu !!! |
Yayyyyyy this is great!! 🎉 🎉 🎉 🎉 |
Amazing!! Thanks @jywarren |
* add nearby activity * comment out pending test to test if it passes * revert old test * add example/images/owmloading.gif direct link to assets location * test if test will fail * test if test will fail * re-add test for owmloading error * removed dup lines from merge Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
* add nearby activity * comment out pending test to test if it passes * revert old test * add example/images/owmloading.gif direct link to assets location * test if test will fail * test if test will fail * re-add test for owmloading error * removed dup lines from merge Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
* add nearby activity * comment out pending test to test if it passes * revert old test * add example/images/owmloading.gif direct link to assets location * test if test will fail * test if test will fail * re-add test for owmloading error * removed dup lines from merge Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Fixes #9159
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowBefore
After adding location