-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out moderators for moderator email notifications #9269
Conversation
@jywarren, I could not find any tag named |
Codecov Report
@@ Coverage Diff @@
## main #9269 +/- ##
=======================================
Coverage ? 82.28%
=======================================
Files ? 98
Lines ? 5864
Branches ? 0
=======================================
Hits ? 4825
Misses ? 1039
Partials ? 0 |
ccc46fb
to
b48d8a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just the one tweak in the conditional and we can merge! I'm going to resolve/ignore the CodeClimate requests as the code looks pretty tidy. Thanks!!
Code Climate has analyzed commit b6c8d25 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
b6c8d25
to
7b746a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you so much!!!!
Excellent work!!!! Thanks everyone for the reviews as well! 🎉 |
* Filter out moderators for moderator email notifications * Added notifications:noemail tag to filter moderator emails
* Filter out moderators for moderator email notifications * Added notifications:noemail tag to filter moderator emails
Fixes #9114
@publiclab/reviewers
for help, in a comment below