Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forgeblocks.com to psl #1238

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Added forgeblocks.com to psl #1238

merged 1 commit into from
Mar 25, 2021

Conversation

roderickparr
Copy link
Contributor

@roderickparr roderickparr commented Mar 23, 2021

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Description of Organization We are a PaaS delivering customer identity and access management service

Organization Website: forgerock.com

Reason for PSL Inclusion Many web security features (notably cookies) rely on the notion of "registerable domain" (eTLD+1) rather than origin for their security boundary. Under this definition, every tenant could be in the same security context, and can for example overwrite each others' cookies and potentially steal them if misconfigured.

DNS Verification via dig

make test

@dnsguru
Copy link
Member

dnsguru commented Mar 23, 2021

@roderickparr please fill out the info above in order for this to get reviewed or proceed

@dnsguru dnsguru added the waiting-followup Blocked for need of follow-up label Mar 23, 2021
@dnsguru dnsguru self-assigned this Mar 23, 2021
@roderickparr
Copy link
Contributor Author

@roderickparr please fill out the info above in order for this to get reviewed or proceed

Does the TXT record need to include the https://github.com/publicsuffix/list/pull/XXXX in the TXT data? or is that. part of the dig request?

@dnsguru
Copy link
Member

dnsguru commented Mar 23, 2021

the record would be
_psl IN TXT "#1238"

In the DNS.

Can you put a bit more oopmh into the description above? The marketing blurb / compnay description is less important than the rationale for why you want this entry included in the PSL.

@dnsguru
Copy link
Member

dnsguru commented Mar 23, 2021

That's a sufficient rationale - please ensure the DNS entry is correct - it appears it got processed by markup:

_psl  IN TXT "https://github.com/publicsuffix/list/pull/1238"

is what it should say.

@roderickparr
Copy link
Contributor Author

DNS TXT record has been added.

@roderickparr
Copy link
Contributor Author

Is this ok to merge?

@dnsguru dnsguru removed the waiting-followup Blocked for need of follow-up label Mar 25, 2021
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DNS Validation ok
  • Tests ok
  • Rationale ok
  • No conflict with base

Approved

@dnsguru dnsguru merged commit 161070f into publicsuffix:master Mar 25, 2021
@dnsguru
Copy link
Member

dnsguru commented Mar 25, 2021

@roderickparr Merged! cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants